Skip to content

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Mar 19, 2025

What changes were proposed in this pull request?

This PR aims to remove build warnings on try expression in SparkSession.

Why are the changes needed?

Due to the unnecessary try, it shows repetitive warnings currently.

/Users/dongjoon/APACHE/spark-connect-swift/Sources/SparkConnect/SparkSession.swift:109:12: warning: no calls to throwing functions occur within 'try' expression
107 |   /// - Returns: A ``DataFrame`` instance.
108 |   public func range(_ start: Int64, _ end: Int64, _ step: Int64 = 1) async throws -> DataFrame {
109 |     return try await DataFrame(spark: self, plan: client.getPlanRange(start, end, step))
    |            `- warning: no calls to throwing functions occur within 'try' expression
110 |   }
111 |
/Users/dongjoon/APACHE/spark-connect-swift/Sources/SparkConnect/SparkSession.swift:109:12: warning: no calls to throwing functions occur within 'try' expression
107 |   /// - Returns: A ``DataFrame`` instance.
108 |   public func range(_ start: Int64, _ end: Int64, _ step: Int64 = 1) async throws -> DataFrame {
109 |     return try await DataFrame(spark: self, plan: client.getPlanRange(start, end, step))
    |            `- warning: no calls to throwing functions occur within 'try' expression
110 |   }
111 |
/Users/dongjoon/APACHE/spark-connect-swift/Sources/SparkConnect/SparkSession.swift:109:12: warning: no calls to throwing functions occur within 'try' expression
107 |   /// - Returns: A ``DataFrame`` instance.
108 |   public func range(_ start: Int64, _ end: Int64, _ step: Int64 = 1) async throws -> DataFrame {
109 |     return try await DataFrame(spark: self, plan: client.getPlanRange(start, end, step))
    |            `- warning: no calls to throwing functions occur within 'try' expression
110 |   }
111 |

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun
Copy link
Member Author

Thank you, @viirya .

@dongjoon-hyun dongjoon-hyun changed the title [MINOR] Remove build warning on try expression in SparkSession [MINOR] Remove build warnings on try expression in SparkSession Mar 19, 2025
@dongjoon-hyun
Copy link
Member Author

Merged to main.

@dongjoon-hyun dongjoon-hyun deleted the buildwarning branch March 19, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants